Unnecessary Abstractions
A code review facepalm: someone hand-rolled IP address parsing logic that .NET's built-in IPAddress class already handles perfectly.
Jason Bock had a similar title to this post awhile back … and I found a forehead-slapper today when reviewing some code in a app I’m working on during my free time. I seriously said “What the
Here’s the code:
There is absolutely no need to do this. This is exactly WHAT the IPAddress class does. The worst part is that the programmer who developed this knew that the IPAddress Class existed. I’m amazed daily.
